Discussion:
[Netatalk-git]Netatalk git repository. branch, data-corruption, created. netatalk-2-1-4-1469-g406ab67
franklahm
2012-08-19 06:04:32 UTC
Permalink
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Netatalk git repository.".

The branch, data-corruption has been created
at 406ab67a6c4c960ab71ddfa83d60c778174556a5 (commit)

- Log -----------------------------------------------------------------
commit 406ab67a6c4c960ab71ddfa83d60c778174556a5
Author: Frank Lahm <***@googlemail.com>
Date: Sat Aug 18 21:50:03 2012 +0200

read buffer must be initialized early

Previous commit made the commands read buffer an allocated buffer
which is used in dsi_tcp, thus it must be allocated right after
forking

commit 668d10e1725cb85e18e4987e50c3b1986d6306fc
Author: Frank Lahm <***@googlemail.com>
Date: Sat Aug 18 18:24:42 2012 +0200

Fix data corruption bug

Received data from the client was written to the read-ahead buffer
from dsi_peek() which caused data corrution.
Fix is: change the DSI command buffer from static 8192 bytes to
an allocated buffer of size DSI quantum and use this buffer in
dsi_write/write_fork. That just requires dsi_writeinit to use
memmove instead of memcpy, because now we use the same buffer

-----------------------------------------------------------------------


hooks/post-receive
--
Netatalk git repository.
Loading...